[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Configure TCSS D3Cold for pre-QS and QS platforms

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43980 )

Change subject: soc/intel/tigerlake: Configure TCSS D3Cold for pre-QS and QS platforms
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43980/3/src/soc/intel/tigerlake/fsp... 
File src/soc/intel/tigerlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/43980/3/src/soc/intel/tigerlake/fsp... 
PS3, Line 123: TcssD3ColdEnable
> i think it's reasonable to include the 1-line edits to the 3 devicetree.cb […]

If TCSS D3Cold is expected to be enabled in most cases, then I agree that we should rename it. Only one negation, though:

params->D3ColdEnable = !config->TcssD3ColdDisable;

We should also rename TcssD3HotEnable, too.