Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85613?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek/mt8196: Add pwrsel driver
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File src/soc/mediatek/mt8196/mtk_pwrsel.c:
https://review.coreboot.org/c/coreboot/+/85613/comment/3c674aae_f62fd982?usp... :
PS3, Line 23: msut
must
https://review.coreboot.org/c/coreboot/+/85613/comment/3cd8ff6d_15e69370?usp... :
PS3, Line 25: msut
must
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85613?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib1b8588810fdad5c675dee865627337269b57d18
Gerrit-Change-Number: 85613
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Wed, 18 Dec 2024 07:30:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes