Attention is currently required from: Martin L Roth.
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83693?usp=email )
Change subject: [UNTESTED] Makefile: Move `--no-warn-rwx-segments' into xcompile ......................................................................
[UNTESTED] Makefile: Move `--no-warn-rwx-segments' into xcompile
Change-Id: I02982769ae2c356f037a747e85d155368bfcb730 Signed-off-by: Nico Huber nico.h@gmx.de --- M Makefile.mk M util/xcompile/xcompile 2 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/83693/1
diff --git a/Makefile.mk b/Makefile.mk index e9ad2cc..901d6b2 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -604,9 +604,6 @@ LDFLAGS_common += --nmagic LDFLAGS_common += -static LDFLAGS_common += -z noexecstack -# Disable warning on segments with RWX. -# All loadable sections are placed in the same segment for simplicity. -LDFLAGS_common += --no-warn-rwx-segments
# Workaround for RISC-V linker bug, merge back into above line when fixed. # https://sourceware.org/bugzilla/show_bug.cgi?id=27180 diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index b3012b5..4c5285f 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -208,6 +208,12 @@ testcc "$GCC" "$CFLAGS_GCC -Wcalloc-transposed-args" && CFLAGS_GCC="$CFLAGS_GCC -Wcalloc-transposed-args"
+ # Disable warning on segments with RWX. + # All loadable sections are placed in the same segment for simplicity. + testld "$GCC" "$FLAGS_GCC" "${GCCPREFIX}ld${LINKER_SUFFIX}" \ + "$LDFLAGS --no-warn-rwx-segments" && \ + LDFLAGS="$LDFLAGS --no-warn-rwx-segments" + case "$architecture" in x86) ;;