17 Sep
2024
17 Sep
'24
10:19 a.m.
Attention is currently required from: Bora Guvendik, Cliff Huang.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84392?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/common/block/acpi: Fix GPE1 blocks to ACPI FADT table ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/84392/comment/32c69e01_6426ff17?usp... : PS2, Line 111: HAVE do you wish to land this CL as is or plan to change SOC_INTEL_COMMON_BLOCK_ACPI_HAVE_GPE1 to SOC_INTEL_COMMON_BLOCK_ACPI_USE_GPE1 ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84392?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idd8115044faff3161ea6bd1cae6c0fe8aa0ff8d7
Gerrit-Change-Number: 84392
Gerrit-PatchSet: 2
Gerrit-Owner: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Hannah Williams hannah.williams@intel.com
Gerrit-Attention: Bora Guvendik bora.guvendik@intel.com
Gerrit-Attention: Cliff Huang cliff.huang@intel.com
Gerrit-Comment-Date: Tue, 17 Sep 2024 08:19:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes