[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/common: Make ramtop offset configurable

[Dinesh Gehlot (Code Review)]

Attention is currently required from: Sean Rhodes, Subrata Banik, Lean Sheng Tan.

Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74511 )

Change subject: soc/intel/common: Make ramtop offset configurable
......................................................................

Patch Set 5:

(1 comment)

File src/soc/intel/common/basecode/ramtop/ramtop.c:

https://review.coreboot.org/c/coreboot/+/74511/comment/86adc49a_25d3f011 
PS5, Line 19: RAMTOP_CMOS_OFFSET
In the earlier code, the `RAMTOP_CMOS_OFFSET` macro was set to a fixed value of 100. The cmos_write() function used this value to write to the CMOS memory. In current changes cmos_write() uses newly created configurable option `CONFIG_RAMTOP_OFFSET` to write CMOS memory.

However, RAMTOP_CMOS_OFFSET is still defined, even though it is not used anywhere in this file. I am curious about the uses of RAMTOP_CMOS_OFFSET. Could you please explain?