Attention is currently required from: Julia Kittlinger.
Elyes Haouas has posted comments on this change by Julia Kittlinger. ( https://review.coreboot.org/c/coreboot/+/83968?usp=email )
Change subject: mb/acer/g43t-am3: Add Acer Q45T-AM as a variant
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/acer/g43t-am3/variants/q45t-am/early_init.c:
https://review.coreboot.org/c/coreboot/+/83968/comment/64d9e93a_03bcfc23?usp... :
PS3, Line 7: <superio/ite/it8720f/it8720f.h>
Why do you think this is unused? Look at the bootblock_mainboard_early_init() below, which is using […]
indeed, my mistake.
<southbridge/intel/i82801jx/i82801jx.h> is unused
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83968?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic2654ca4b198bfea409992be14e89702cf67ea50
Gerrit-Change-Number: 83968
Gerrit-PatchSet: 4
Gerrit-Owner: Julia Kittlinger
julia.kittlinger@pm.me
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Julia Kittlinger
julia.kittlinger@pm.me
Gerrit-Comment-Date: Thu, 22 Aug 2024 18:56:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr