Attention is currently required from: Jérémy Compostella.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84402?usp=email )
Change subject: efi: Set EFIAPI to 32-bit ABI for FSP1_1
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84402/comment/68950420_22903229?usp... :
PS2, Line 7: FSP1_1
The problem is the issue won't reproduce before the following patch so it is bit weird to mention that isn't it ?
every patch should have a TEST line to ensure what is the level of sanity here. what is weird here, cyan is FSP 1.1 platform.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84402?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5d
Gerrit-Change-Number: 84402
Gerrit-PatchSet: 2
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Wed, 18 Sep 2024 04:39:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com