Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 34:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35427/30//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35427/30//COMMIT_MSG@10 PS30, Line 10:
Please add what was tested. (Or refer to the documentation.)
mentioned documentation
there can’t be one image that supports the same series (from the baseboard) would be appreciated
That should be obvious (think of GPIO etc.) but I added a short statement
https://review.coreboot.org/c/coreboot/+/35427/30/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/30/Documentation/mainboard/su... PS30, Line 37: Tianocore
TianoCore
done in CB:35547
https://review.coreboot.org/c/coreboot/+/35427/30/Documentation/mainboard/su... PS30, Line 60: ## Tested and working
What payload and OS version?
Done
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... PS25, Line 22: #ifndef __ACPI__
This was copied from x11ssh. I have no clue. […]
removed; done