Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45287 )
Change subject: amdfwtool: Apply the change of config file to stoneyridge ......................................................................
Patch Set 22:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45287/22/src/soc/amd/stoneyridge/fw... File src/soc/amd/stoneyridge/fw_cz.cfg:
https://review.coreboot.org/c/coreboot/+/45287/22/src/soc/amd/stoneyridge/fw... PS22, Line 3: #XHCI_FWM_FILE xhci.bin It might be useful to call this TODO out in the commit message as remaining as a command line option or if there is a plan to allow it to be specified as either config or command line in the future.
https://review.coreboot.org/c/coreboot/+/45287/22/src/soc/amd/stoneyridge/fw... File src/soc/amd/stoneyridge/fw_st.cfg:
https://review.coreboot.org/c/coreboot/+/45287/22/src/soc/amd/stoneyridge/fw... PS22, Line 4: #XHCI_FWM_FILE xhci.bin Same, it would be useful to understand why this is included but commented out in the cfg.