Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35147 )
Change subject: mediatek/mt8183: Allow modifying vdram2 voltage
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35147/4/src/soc/mediatek/mt8183/mt6...
File src/soc/mediatek/mt8183/mt6358.c:
https://review.coreboot.org/c/coreboot/+/35147/4/src/soc/mediatek/mt8183/mt6...
PS4, Line 910: if (vdram2_uv > 680000) {
: assert(0);
: return;
: } else if (vdram2_uv < 530000) {
: assert(0);
: return;
: }
Why not just […]
Are we going to fix this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35147
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f0d82596a1709bf0d37885f257646133f18f210
Gerrit-Change-Number: 35147
Gerrit-PatchSet: 10
Gerrit-Owner: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: Ben Ho
Ben.Ho@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-Comment-Date: Tue, 01 Oct 2019 08:24:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment