Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45644 )
Change subject: mb/google/zork: Modify I2C3 CLK for Woomax to meet I2C specification
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45644/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45644/4//COMMIT_MSG@15
PS4, Line 15: .fall_time_ns = 34
Might be worth noting what the frequency is now vs before or what these changes accomplished.
Dear Aaron,
Original setting measured value about 407~408kHz, the measured value after modification is lower than 400kHz(about 397kHz), thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45644
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f0b791c3e701ebf6b336a8cb259eeb74c46af5a
Gerrit-Change-Number: 45644
Gerrit-PatchSet: 4
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Fri, 25 Sep 2020 02:14:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment