Attention is currently required from: Furquan Shaikh, Aaron Durbin.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49334 )
Change subject: cbfs: Add cbfs_alloc() primitive and combine cbfs_load() and cbfs_map()
......................................................................
Patch Set 1:
(1 comment)
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/49334/comment/06e04256_3c4b4c61
PS1, Line 350: } else {
else is not generally useful after a break or return
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49334
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fe0645387c0e9053ad5c15744437940fc904392
Gerrit-Change-Number: 49334
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Tue, 12 Jan 2021 02:05:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment