[coreboot-gerrit] Change in coreboot[master]: src/drivers/intel/fsp2_0: allow larger FSP 2.0 header

[Furquan Shaikh (Code Review)]

Attention is currently required from: Martin Roth, Marshall Dawson, Nikolai Vyssotski, Andrey Petrov, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56190 )

Change subject: src/drivers/intel/fsp2_0: allow larger FSP 2.0 header
......................................................................

Patch Set 2: Code-Review-2

(1 comment)

File src/drivers/intel/fsp2_0/include/fsp/info_header.h:

https://review.coreboot.org/c/coreboot/+/56190/comment/b1cfa114_4da88906 
PS2, Line 13:  however, some FSP 2.0 variants have it as well.
Then it is not conforming to FSP specification:

http://www.intel.com/content/dam/www/public/us/en/documents/technical-specif...

https://cdrdv2.intel.com/v1/dl/getContent/627153

FspMultiPhaseSiInitEntryOffset was added in FSP v2.2 and v2.0 must not have this field. If you are moving to a newer EDK2 version, then I believe you will have to ensure that your FSP implementation conforms to FSP v2.2. Making this change in coreboot is not correct. It violates the spec.