Attention is currently required from: Furquan Shaikh, Paul Menzel, Sugnan Prabhu S, Subrata Banik. Sathya Prakash M R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56208 )
Change subject: mb/intel/adlrvp: Use HDA TMODE 8T to match spec for ADL P RVP ......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56208/comment/8e7e9ea5_9cdcf36d PS1, Line 7: mb/intel/adlrvp: Fix Tmode setting for ADL P RVP
Please be more specific and rephrase to something like: […]
DONE
https://review.coreboot.org/c/coreboot/+/56208/comment/1f5a4ed4_f0345baf PS1, Line 8:
Please describe the problem first: […]
Done
https://review.coreboot.org/c/coreboot/+/56208/comment/bc4ac5a7_7bfbaedd PS1, Line 13: Earlier setting was with older FSP which was carry forwarded.
What FSP version did you test with?
Done
https://review.coreboot.org/c/coreboot/+/56208/comment/7d650955_84c915b7 PS1, Line 13: carry
carried
Done
https://review.coreboot.org/c/coreboot/+/56208/comment/c3eb03dc_89beb858 PS1, Line 16: HDMI /DP
HDMI/DP
Done
https://review.coreboot.org/c/coreboot/+/56208/comment/b759bd2c_48794ed8 PS1, Line 17:
Please add a fixes tag: […]
Sorry, not exactly clear on this ? there is no external bug on this - so what should be added under Fixes: ?