Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34188 )
Change subject: mb/google/octopus/variants/garg: support LTE power sequence. ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34188/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/smihandler.c:
https://review.coreboot.org/c/coreboot/+/34188/1/src/mainboard/google/octopu... PS1, Line 37: !gpio_get_output(GPIO_LTE_RESET)
Is it really necessary to check this? I am guessing that the GPIOs which are used for LTE remain not […]
The intention is to reduce the effect of delaying to other variants and will check with HW Eng as well.
https://review.coreboot.org/c/coreboot/+/34188/1/src/mainboard/google/octopu... PS1, Line 56: lte_power_off_gpios
Since all these GPIOs are outputs and are being set to 0, you can simply have a struct with GPIO# an […]
Copy that and will try.
https://review.coreboot.org/c/coreboot/+/34188/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/34188/1/src/mainboard/google/octopu... PS1, Line 333: PAD_CFG_GPO_IOSSTATE_IOSTERM
Is there no power on sequencing requirements?
Regarding power on sequence, the only requirement is that there should be a gap (larger then 10ms) between 67/117 (3.3V/CARD_POWER) and 161(RESET). Therefore we enable 67/117 in bootblock then enable 161 in ramstage which are override in garg variants.
https://review.coreboot.org/c/coreboot/+/34188/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/baseboard/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/34188/1/src/mainboard/google/octopu... PS1, Line 37: TGPIO_161
GPIO_161?
Ack and found that build will get failed when I move this CL into chromium repo for testing. Thanks.