Attention is currently required from: Tarun Tuli, Wonkyu Kim, Ravishankar Sarawadi, Tim Wawrzynczak, Kapil Porwal, Srinidhi N Kaushik, Raj Astekar.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64883 )
Change subject: vendorcode/intel/fsp/fsp2_0/mtl: Add FSP header files for Meteor Lake
......................................................................
Patch Set 1:
(3 comments)
File src/vendorcode/intel/fsp/fsp2_0/meteorlake/MemInfoHob.h:
https://review.coreboot.org/c/coreboot/+/64883/comment/640327ac_6cbda648
PS1, Line 2: This file contains definitions required for creation of
: Memory S3 Save data, Memory Info data and Memory Platform
: data hobs.
Could the full line length be used?
https://review.coreboot.org/c/coreboot/+/64883/comment/dc01c3c5_b6991370
PS1, Line 7: <BR>
Does this need to be in the header?
https://review.coreboot.org/c/coreboot/+/64883/comment/6cecd7c5_e68b7f7a
PS1, Line 11: http://opensource.org/licenses/bsd-license.php.
Use HTTPS to save a redirect?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64883
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b1caa4bc09f09005859e6c8853d14b8f96a26ff
Gerrit-Change-Number: 64883
Gerrit-PatchSet: 1
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Comment-Date: Thu, 02 Jun 2022 11:19:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment