Attention is currently required from: Tim Wawrzynczak. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60995 )
Change subject: mb/google/brya: Add GPIO table for nissa ......................................................................
Patch Set 8:
(4 comments)
Patchset:
PS8:
There are few open comments but I don't think these are related to the code directly, hence +2.
Yeah, I think the only unresolved issues are checking the WWAN and SSD power sequencing requirements. But I don't think those need to block this going in. I'll file bugs for checking the requirements on Monday.
File src/mainboard/google/brya/variants/baseboard/nissa/gpio.c:
https://review.coreboot.org/c/coreboot/+/60995/comment/bf6657c3_9381977a PS1, Line 374: NF1
EC pinmap has been updated : https://chromium-review.googlesource. […]
Done
File src/mainboard/google/brya/variants/baseboard/nissa/gpio.c:
https://review.coreboot.org/c/coreboot/+/60995/comment/52f669f7_528b7156 PS3, Line 409: };
I'll check if we have datasheets yet.
Marking resolved. I'll file a bug to check the requirements on Monday.
File src/mainboard/google/brya/variants/baseboard/nissa/gpio.c:
https://review.coreboot.org/c/coreboot/+/60995/comment/52d8a96e_af0933e7 PS6, Line 109: EN_PP3300_UCAM_X
If you want you can but I don't think it is necessary
Ack. I'll just leave it as is.