Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33249
Change subject: security/tpm/tss/tcg-2.0/tss.c: Report debug error on tis failure ......................................................................
security/tpm/tss/tcg-2.0/tss.c: Report debug error on tis failure
No debug error is reported on tis_init() or tis_open() error. Print debug error when tis_init() or tis_open() returned error.
BUG=N/A TEST=Build binary and verified logging on Facebook FBG-1701
Change-Id: If912eb258152712ca526aa5a5ab9dec1c0b3d303 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/security/tpm/tss/tcg-2.0/tss.c 1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/33249/1
diff --git a/src/security/tpm/tss/tcg-2.0/tss.c b/src/security/tpm/tss/tcg-2.0/tss.c index e579bff..c4b5538 100644 --- a/src/security/tpm/tss/tcg-2.0/tss.c +++ b/src/security/tpm/tss/tcg-2.0/tss.c @@ -181,10 +181,15 @@ if (done) return VB2_SUCCESS;
- if (tis_init()) + if (tis_init()) { + printk(BIOS_ERR, "%s: tis_init returned error\n", __func__); return VB2_ERROR_UNKNOWN; - if (tis_open()) + } + + if (tis_open()) { + printk(BIOS_ERR, "%s: tis_open returned error\n", __func__); return VB2_ERROR_UNKNOWN; + }
car_set_var(tlcl_init_done, 1);