Attention is currently required from: Ravi kumar.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49392 )
Change subject: sc7280: Add SHRM firmware support
......................................................................
Patch Set 79:
(1 comment)
File src/soc/qualcomm/sc7280/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/49392/comment/e90b3316_a4dd0c58
PS79, Line 110: none
Somehow when either lz4 or lzma is used, a runtime exception is thrown as ravi mentioned in https:// […]
Oh, sorry, yeah... I only pay occasional attention to these so I missed Ravi's response. I think maybe directly decompression into the SHRM memory is the problem because it is mapped with the device memory type, and I think that only allows 4-byte aligned accesses. Maybe mapping it as cached memory (temporarily, and then flushing it before starting the SHRM) would help.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49392
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44484573a829eaefbd34907c6fe78d427506a762
Gerrit-Change-Number: 49392
Gerrit-PatchSet: 79
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Comment-Date: Thu, 07 Oct 2021 23:03:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment