Attention is currently required from: Bora Guvendik, Anil Kumar K, Jakub Czapiga, Selma Bensaid, Tim Wawrzynczak, Julius Werner.
Balaji Manigandan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63240 )
Change subject: libpayload/defconfig: enable vboot Lib Build
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63240/comment/3b424b28_aa8b9fe1
PS3, Line 9: #3461454
Sorry, I don't quite understand the use case here and I disagree with the conclusion. […]
We require to build Coreboot (with Depthcharge) outside the ChromeOS SDK, with default configs in coreboot, we hit a compilation error after this new change. Within the ChromeOS sdk, this is managed by a separate config.<BOARD>. We wanted to avoid creation of multiple configs for each board.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63240
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2bb2ce42a314e05ef22ea7b8abc067d6361d511
Gerrit-Change-Number: 63240
Gerrit-PatchSet: 5
Gerrit-Owner: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhixing Ma
zhixing.ma@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 14 Apr 2022 10:14:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Selma Bensaid
selma.bensaid@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-MessageType: comment