Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44270 )
Change subject: soc/intel/jasperlake: Disable IPU based on devicetree ......................................................................
soc/intel/jasperlake: Disable IPU based on devicetree
FSP enables IPU by default even if its disabled in devicetree. We need to fill FSP upd based on the device enablement in devicetree.
BUG=None BRANCH=None TEST=IPU is disabled and doesn't show in lspci.
Change-Id: I0f9a40e85427fd88bb12a40770ecf7b939b1d8cd Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/soc/intel/jasperlake/romstage/fsp_params.c 1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/44270/1
diff --git a/src/soc/intel/jasperlake/romstage/fsp_params.c b/src/soc/intel/jasperlake/romstage/fsp_params.c index 809ae80..9207a82 100644 --- a/src/soc/intel/jasperlake/romstage/fsp_params.c +++ b/src/soc/intel/jasperlake/romstage/fsp_params.c @@ -66,10 +66,16 @@ m_cfg->CpuTraceHubMode = config->TraceHubMode; }
+ /* IPU configuration */ + /* By default IPU is enabled, need to disable in FSP if pci device is disabled */ + dev = pcidev_path_on_root(SA_DEVFN_IPU); + if (!is_dev_enabled(dev)) { + m_cfg->SaIpuEnable = 0; + } + /* Change VmxEnable UPD value according to ENABLE_VMX Kconfig */ m_cfg->VmxEnable = CONFIG(ENABLE_VMX);
- /* Enable SMBus controller based on config */ m_cfg->SmbusEnable = config->SmbusEnable;