Attention is currently required from: Subrata Banik, Maulik V Vaghela, Paul Menzel, Sugnan Prabhu S, Tim Wawrzynczak, Patrick Rudolph.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61146 )
Change subject: driver/intel/mipi_camera: Increase max power ops count to 6
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61146/comment/03b6f8f6_b6aa786e
PS4, Line 9: Current max count for camera power ops is 5 which is not sufficient,
Please make that a sentence by itself (dot/period and no comma). […]
So if you see the patch on top of it explains in detail why we need it, its because of hardware limitation, two devices sharing the same reset PCH GPIO
https://review.coreboot.org/c/coreboot/+/61146/comment/0df06fe2_eef1540d
PS4, Line 10: if we increase the ops by 1 in current variants the compiler
: will throw error for intel mipi camera driver
- Please add a dot/period at the end of sentences. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61146
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f4c090f2275616816dfc697f27520cd1cbc1a80
Gerrit-Change-Number: 61146
Gerrit-PatchSet: 6
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 27 Jan 2022 08:36:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment