Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37755 )
Change subject: AGESA fam14: Set Ontario link data
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37755/1/src/drivers/amd/agesa/bootb...
File src/drivers/amd/agesa/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37755/1/src/drivers/amd/agesa/bootb...
PS1, Line 54: LibAmdPciWrite(AccessWidth32, PciAddress, &PciData, &StdHeader);
These write the PCI subsystem id and subvendor id. It doesn't even control any hardware most likely.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37755
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc4f22d2f9396fdededa3f329015194c826bd8e9
Gerrit-Change-Number: 37755
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Dec 2019 18:36:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment