Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39305 )
Change subject: cbfs: Port cbfs_load() and cbfs_map() to new API
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39305/7/src/commonlib/bsd/cbfs_priv...
File src/commonlib/bsd/cbfs_private.c:
https://review.coreboot.org/c/coreboot/+/39305/7/src/commonlib/bsd/cbfs_priv...
PS7, Line 172: return attr;
Should we be checking length of attribute actually fits within mdata? i.e. offset + len <= end?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39305
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I754cc34b1c1471129e15475aa0f1891e02439a02
Gerrit-Change-Number: 39305
Gerrit-PatchSet: 7
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 09 Oct 2020 01:14:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment