Attention is currently required from: Keith Hui, Branden Waldner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59766 )
Change subject: [Untested]cpu/x86/mp.h: Implement a pre-SSE2 mfence ......................................................................
Patch Set 4:
(3 comments)
File src/include/cpu/x86/mp.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139573): https://review.coreboot.org/c/coreboot/+/59766/comment/e9758ccb_aa3332e5 PS4, Line 18: __asm__ __volatile__("mfence\t\n": : :"memory"); spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139573): https://review.coreboot.org/c/coreboot/+/59766/comment/90bf6b58_9bc3aedd PS4, Line 18: __asm__ __volatile__("mfence\t\n": : :"memory"); spaces required around that ':' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139573): https://review.coreboot.org/c/coreboot/+/59766/comment/330f78a0_2ca416fa PS4, Line 20: __asm__ __volatile__("lock; addl $0,0(%%esp)": : : "memory"); spaces required around that ':' (ctx:VxW)