Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45458 )
Change subject: mb/google/dedede: Enable I2C5 pads ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45458/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45458/1//COMMIT_MSG@9 PS1, Line 9: Waddledee Nit: Waddledee -> Dedede
https://review.coreboot.org/c/coreboot/+/45458/1//COMMIT_MSG@13 PS1, Line 13: build and boot Nit: Build and boot Waddledee.
https://review.coreboot.org/c/coreboot/+/45458/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/45458/1/src/mainboard/google/dedede... PS1, Line 187: AP_I2C_SUB_SDA Nit: AP_I2C_SUB_SDA/AP_I2C_CAM_SDA. Same for SCL.