Attention is currently required from: Subrata Banik, Ethan Tsao, Ravishankar Sarawadi, Stefan Reinauer, Tim Wawrzynczak.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61576 )
Change subject: util/ifdtool: add PLATFORM_IFD2 to reduce common ifd tool change
......................................................................
Patch Set 3:
(1 comment)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/61576/comment/d3bbf56f_17ceb420
PS2, Line 1641: pv1
ifd2 ? […]
I'll update this as ifd2.
For clean up, I think we may need to consider more and it's better to be done in later patch. The main issue is ADL,TGL and other platforms in IFDv2 has different SPI frequence decode values.
_decode_spi_frequency vs _decode_spi_frequency_500_series.
So, either I think we may
1. clean ADL/TGL and use only IFD2
2. Consider removing SPI prequency encode/decode from ifd tool.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61576
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14a71a58c7d51b9c8b92e013b5637c6b35005f22
Gerrit-Change-Number: 61576
Gerrit-PatchSet: 3
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Mon, 07 Feb 2022 23:22:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment