Attention is currently required from: Bob Moragues, David Wu, Kane Chen, Nick Vaccaro, Tarun Tuli.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75990?usp=email )
Change subject: mb/google/brya: Add support for variant_memcfg_init()
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I agree with Nick. […]
I don't think copied all the same thing with only one different is good. unless we can remove the const for the mem_config then we can do override in variant_memory_params.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75990?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4926139e36602f87c8317ab4b476636e02f87771
Gerrit-Change-Number: 75990
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Tue, 27 Jun 2023 01:18:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Comment-In-Reply-To: David Wu
david_wu@quanta.corp-partner.google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment