Hello Philipp Deppenwiese, build bot (Jenkins), Shaunak Saha, Marc Jones, Duncan Laurie, Christian Walter, Angel Pons, Arthur Heymans, Michael Niewöhner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48691
to look at the new patch set (#2).
Change subject: soc/intel/common/block/acpi: Fix get_cores_per_package ......................................................................
soc/intel/common/block/acpi: Fix get_cores_per_package
Current implementation uses CPUID 0Bh function that returns the number of logical cores of requested level. The problem with this approach is that this value doesn't change when HyperThreading is disabled (it's in the Intel docs), so it breaks generate_cpu_entries() because `numcpus` ends up being zero due to integer division truncation.
- Use MSR 0x35 instead, which returns the correct number of logical processors with and without HT.
- Use cpu_read_topology() to gather the required information
Tested on Prodrive Hermes, the ACPI code is now generated even with HyperThreading disabled.
Change-Id: Id9b985a07cd3f99a823622f766c80ff240ac1188 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/soc/intel/common/block/acpi/acpi.c 1 file changed, 13 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/48691/2