Attention is currently required from: Martin Roth, Mathew King, EricR Lai, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51043 )
Change subject: mb/google/guybrush: Enable Chrome EC ......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/guybrush/mainboard.c:
https://review.coreboot.org/c/coreboot/+/51043/comment/c25ddf50_6d85ab71 PS4, Line 22: mainboard_ec_init
eSPI GPIOs are configured in verstage in zork, I could add eSPI GPIO configuration to bootbock for n […]
I would prefer it works with psp verstage and without.
For zork we defined the early_gpio_table: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
Can we call that from bootblock when !VBOOT_STARTS_BEFORE_BOOTBLOCK?
File src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/51043/comment/affe053c_84bb50df PS4, Line 26: SMI
SMI is needed for depthcharge receive LID close, right? I thought Intel platform had this issue due […]
ah, I thought depthcharge polled for lid closed. We configure the switch here: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/pl...
But it looks like we also have the SMI handler configured here: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
I'm fine leaving it.