Attention is currently required from: Arthur Heymans, Cliff Huang, Krystian Hebel, Lance Zhao.
Paul Menzel has posted comments on this change by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/82698?usp=email )
Change subject: acpi/acpi.c: fix XSDT handling on QEMU
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82698/comment/2caa69f2_e68da849?usp... :
PS1, Line 9: c2830c9
Should you amend the commit message, please use
Commit c2830c96616c ("acpi.c: Add XSDT on QEMU") …
https://review.coreboot.org/c/coreboot/+/82698/comment/3421a950_985d0708?usp... :
PS1, Line 17:
For ease, please add the command line you used for testing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82698?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7f38467b7de3f35fc3ec3854a840de8345cd0fe5
Gerrit-Change-Number: 82698
Gerrit-PatchSet: 1
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Sat, 01 Jun 2024 16:14:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes