Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32000 )
Change subject: soc/intel/apollolake: Add support to log XHCI wake events ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/32000/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32000/1//COMMIT_MSG@16 PS1, Line 16: S0ix Enter
Works with S3 too?
Yes, checked it and updated the test logs here.
https://review.coreboot.org/#/c/32000/1/src/soc/intel/apollolake/elog.c File src/soc/intel/apollolake/elog.c:
https://review.coreboot.org/#/c/32000/1/src/soc/intel/apollolake/elog.c@28 PS1, Line 28: #define XHCI_USB2_PORT_STATUS_REG 0x480 : #define XHCI_USB3_PORT_STATUS_REG 0x510 : #define XHCI_USB2_PORT_NUM 9 : #define XHCI_USB3_PORT_NUM 7
Are these true for both APL and GLK?
GLK has one additional USB2 port compared to APL. Updated the code accordingly here.
https://review.coreboot.org/#/c/32000/1/src/soc/intel/apollolake/elog.c@33 PS1, Line 33: static struct xhci_usb_info usb_info = {
const
Done