[coreboot-gerrit] [L] Change in coreboot[main]: soc/mediatek: Remove redundant struct pad_func and PAD_* definitions

[Yidi Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Xi Chen, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/84222?usp=email )

Change subject: soc/mediatek: Remove redundant struct pad_func and PAD_* definitions
......................................................................

Patch Set 3:

(3 comments)

File src/soc/mediatek/common/include/soc/gpio_common.h:

https://review.coreboot.org/c/coreboot/+/84222/comment/03ccb729_6acd4bbb?usp... :
PS3, Line 53: struct pad_func {
            : 	gpio_t gpio;
            : 	u8 func;
            : 	enum pull_select select;
            : };
> I thought you'd like to move this to gpio_defs. […]

We can't move `struct pad_func` to `gpio_defs.h`.
1. MT8173 and MT8183 do not include gpio_defs.h.
2. MT8173 needs this struct due to `flash_controller_common.{c|h}`.

An alternative is adding a `struct pad_func` to `soc/gpio.h` for mt8173 and moving `struct pad_func` to `gpio_defs.h`

File src/soc/mediatek/common/include/soc/gpio_defs.h:

https://review.coreboot.org/c/coreboot/+/84222/comment/52d53351_e068f95d?usp... :
PS3, Line 45:
> `(struct pad_func)`

The compiler will raise `error: initializer element is not constant`.

File src/soc/mediatek/mt8183/i2c.c:

https://review.coreboot.org/c/coreboot/+/84222/comment/8dd22171_08a55f35?usp... :
PS3, Line 56: struct pad_func {
> Didn't you say you'd like to leave mt8183 untouched?

please see the reply in the previous comment.