Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44711 )
Change subject: soc/mediatek/mt8192: Add DDR mode register init
......................................................................
Patch Set 50:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44711/50/src/soc/mediatek/mt8192/dr...
File src/soc/mediatek/mt8192/dramc_dvfs.c:
https://review.coreboot.org/c/coreboot/+/44711/50/src/soc/mediatek/mt8192/dr...
PS50, Line 23: = 0
No need to initialize. Or we may write:
u8 tmp_level = (shu_level == DRAM_DFS_SHU0) ? shu_level : 1;
https://review.coreboot.org/c/coreboot/+/44711/50/src/soc/mediatek/mt8192/dr...
PS50, Line 85: wait shu_en ack.
Waiting shu_en ack
Note that:
1. "Waiting" is capitalized
2. No trailing period
https://review.coreboot.org/c/coreboot/+/44711/50/src/soc/mediatek/mt8192/dr...
PS50, Line 102: complete
completed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44711
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If200f4dcef0b1d0b7e901d4ae6e667b1f75156f5
Gerrit-Change-Number: 44711
Gerrit-PatchSet: 50
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 25 Dec 2020 07:49:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment