Attention is currently required from: Paul Menzel, Sean Rhodes.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80179?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: i2c/drivers/generic: Add support for including a rotation matrix
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/i2c/generic/chip.h:
https://review.coreboot.org/c/coreboot/+/80179/comment/7c3e581b_fa1f03eb :
PS4, Line 81: int
using bool would make it more obvious that this is a boolean option and not an integer
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80179?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id4a940d999a0e300a6fe21269f18bab6e3c0523c
Gerrit-Change-Number: 80179
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 19 Feb 2024 17:45:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment