Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31856 )
Change subject: src: Drop unused 'include <arch/ioapic.h>' ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31856/1/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/acpi_tables.c:
https://review.coreboot.org/#/c/31856/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 20: Should we get rind of this extra newline before local includes? There are several files having this "issue" in this patch
https://review.coreboot.org/#/c/31856/1/src/southbridge/amd/cimx/sb900/lpc.c File src/southbridge/amd/cimx/sb900/lpc.c:
https://review.coreboot.org/#/c/31856/1/src/southbridge/amd/cimx/sb900/lpc.c... PS1, Line 18: #include <console/console.h> If you decide to stick with the extra newline before the local includes, then add here one please.