Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian, Mark Hasemeyer.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74107 )
Change subject: mb/google/myst: Log mainboard events to elog ......................................................................
Patch Set 5:
(3 comments)
File src/mainboard/google/myst/variants/baseboard/smihandler.c:
https://review.coreboot.org/c/coreboot/+/74107/comment/2ffa549e_eb42ad8a PS5, Line 16: MAINBOARD_EC_S3_WAKE_EVENTS Why S0IX below, and S3 here?
https://review.coreboot.org/c/coreboot/+/74107/comment/cb42a169_20473f59 PS5, Line 26: void elog_gsmi_cb_mainboard_log_wake_source(void) This isn't implemented for any AMD boards.
Should we add it for the previous boards also?
https://review.coreboot.org/c/coreboot/+/74107/comment/dfa8c65c_707d9067 PS5, Line 28: MAINBOARD_EC_S0IX_WAKE_EVENTS Should this call `acpi_is_wakeup_s3()`, so it uses either `MAINBOARD_EC_S0IX_WAKE_EVENTS` or `MAINBOARD_EC_S3_WAKE_EVENTS`, based on what's enabled?