build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36329 )
Change subject: src/[arch-lib]: change "unsigned" to "unsigned int" ......................................................................
Patch Set 2:
(13 comments)
https://review.coreboot.org/c/coreboot/+/36329/2/src/device/oprom/x86emu/dec... File src/device/oprom/x86emu/decode.c:
https://review.coreboot.org/c/coreboot/+/36329/2/src/device/oprom/x86emu/dec... PS2, Line 880: unsigned int offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36329/2/src/drivers/parade/ps8625/p... File src/drivers/parade/ps8625/ps8625.h:
https://review.coreboot.org/c/coreboot/+/36329/2/src/drivers/parade/ps8625/p... PS2, Line 25: void parade_ps8625_bridge_setup(unsigned int bus, unsigned int chip_base, function definition argument 'const struct parade_write *' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/36329/2/src/drivers/usb/ehci_debug.... File src/drivers/usb/ehci_debug.c:
https://review.coreboot.org/c/coreboot/+/36329/2/src/drivers/usb/ehci_debug.... PS2, Line 438: static int usbdebug_init_(unsigned int ehci_bar, unsigned int offset, struct ehci_debug_info *info) line over 96 characters
https://review.coreboot.org/c/coreboot/+/36329/2/src/drivers/xgi/common/vb_u... File src/drivers/xgi/common/vb_util.h:
https://review.coreboot.org/c/coreboot/+/36329/2/src/drivers/xgi/common/vb_u... PS2, Line 20: extern void xgifb_reg_or(unsigned long, u8, unsigned int); function definition argument 'unsigned long' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/36329/2/src/drivers/xgi/common/vb_u... PS2, Line 20: extern void xgifb_reg_or(unsigned long, u8, unsigned int); function definition argument 'u8' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/36329/2/src/drivers/xgi/common/vb_u... PS2, Line 20: extern void xgifb_reg_or(unsigned long, u8, unsigned int); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/36329/2/src/drivers/xgi/common/vb_u... PS2, Line 21: extern void xgifb_reg_and(unsigned long, u8, unsigned int); function definition argument 'unsigned long' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/36329/2/src/drivers/xgi/common/vb_u... PS2, Line 21: extern void xgifb_reg_and(unsigned long, u8, unsigned int); function definition argument 'u8' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/36329/2/src/drivers/xgi/common/vb_u... PS2, Line 21: extern void xgifb_reg_and(unsigned long, u8, unsigned int); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/36329/2/src/drivers/xgi/common/vb_u... PS2, Line 22: extern void xgifb_reg_and_or(unsigned long, u8, unsigned int, unsigned int); function definition argument 'unsigned long' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/36329/2/src/drivers/xgi/common/vb_u... PS2, Line 22: extern void xgifb_reg_and_or(unsigned long, u8, unsigned int, unsigned int); function definition argument 'u8' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/36329/2/src/drivers/xgi/common/vb_u... PS2, Line 22: extern void xgifb_reg_and_or(unsigned long, u8, unsigned int, unsigned int); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/36329/2/src/drivers/xgi/common/vb_u... PS2, Line 22: extern void xgifb_reg_and_or(unsigned long, u8, unsigned int, unsigned int); function definition argument 'unsigned int' should also have an identifier name