Attention is currently required from: Kapil Porwal, Paul Menzel, Pranava Y N.
Bora Guvendik has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/85525?usp=email )
Change subject: device/pci_ids: Add Pantherlake-H GT2 (DID2)
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85525/comment/db8413d9_9b2147ab?usp... :
PS1, Line 7: IDs
Singular, as you only add one?
Done
https://review.coreboot.org/c/coreboot/+/85525/comment/f2194a6e_d73003fe?usp... :
PS1, Line 7: Add new Intel PTL device IDs for DID2
As the prefix says `pci_ids` maybe just: […]
Done
https://review.coreboot.org/c/coreboot/+/85525/comment/236f3285_35c4a4b7?usp... :
PS1, Line 9: This patch adds new DID2 PCI device ID for Intel PTL.
Where did you get the id from?
https://patchwork.freedesktop.org/patch/624615/?series=141372&rev=1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85525?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4209236ca48f449c22a830c2e44ea8b5909774b
Gerrit-Change-Number: 85525
Gerrit-PatchSet: 2
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Sat, 07 Dec 2024 23:40:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org