[coreboot-gerrit] [XL] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIF and PMIC driver support

[Hope Wang (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.

Hope Wang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85126?usp=email )

Change subject: soc/mediatek/mt8196: Add PMIF and PMIC driver support
......................................................................

Patch Set 16:

(2 comments)

File src/soc/mediatek/mt8196/include/soc/pmif.h:

https://review.coreboot.org/c/coreboot/+/85126/comment/42017417_5ea613d7?usp... :
PS14, Line 114: OFFSET4
> Please use a meaningful name. […]

Done

File src/soc/mediatek/mt8196/pmif_spmi.c:

https://review.coreboot.org/c/coreboot/+/85126/comment/9b542df8_7eb15544?usp... :
PS14, Line 164: 	write32p(SPMI_SCL_OFFSET4_ADDR, 0x100);
              : 	write32p(SPMI_SCL_OFFSET8_ADDR, 0xC0);
              : 	write32p(SPMI_SCL_OFFSET4_ADDR, 0x800);
              : 	write32p(SPMI_SCL_OFFSET8_ADDR, 0x600);
              : 	/* SPMI_P 14mA */
              : 	write32p(SPMI_SCL_OFFSET4_ADDR, 0x6000);
              : 	write32p(SPMI_SCL_OFFSET8_ADDR, 0x1000);
              : 	write32p(SPMI_SCL_OFFSET4_ADDR, 0x30000);
              : 	write32p(SPMI_SCL_OFFSET8_ADDR, 0x8000);
> What about […]

Done