build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 7:
(10 comments)
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 27: int i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 28: const uint16_t port = PID_ITSS; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 30: printk(BIOS_INFO, "ITSS IRQ Polarities BOOTBLOCK\n"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { suspect code indent for conditional statements (3, 5)
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 32: uint16_t reg = PCR_ITSS_IPC0_CONF + sizeof(uint32_t) * i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 33: printk(BIOS_INFO, "IPC%d: 0x%08x\n", i, pcr_read32(port, reg)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 34: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 27: // TODO: on x11ssm FSP does not crash as in x11ssh; even when explicitely setting to 0x0 'explicitely' may be misspelled - perhaps 'explicitly'?
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/todo.txt:
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 13: - (TCO_BASE_LOCK): 1->0 (tco_lock() call in skylake mising) 'mising' may be misspelled - perhaps 'missing'?