[coreboot-gerrit] Change in coreboot[master]: arch/x86: Save the calling argument

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36274 )

Change subject: arch/x86: Save the calling argument
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36274/6/src/arch/x86/c_start.S 
File src/arch/x86/c_start.S:

https://review.coreboot.org/c/coreboot/+/36274/6/src/arch/x86/c_start.S@68 
PS6, Line 68: 	movl	4(%esp), %eax
Took me a while to figure out the need for offset 4 here. Maybe add comment, or just discard the return address with extra 'pop %eax' here?

Which raises another question about the ABI. Looking below how we align %esp, we leave a gap in the stack between return address and the arguments?