[coreboot-gerrit] [L] Change in coreboot[main]: mb/google/brox: Create jubilant variant

[Bob Moragues (Code Review)]

Attention is currently required from: David Wu, Karthik Ramasubramanian, Ren Kuo, Shelley Chen, Subrata Banik, Tyler Wang, YH Lin.

Bob Moragues has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/83212?usp=email )

Change subject: mb/google/brox: Create jubilant variant
......................................................................

Patch Set 15:

(1 comment)

Patchset:

PS15: 
Patch required to get a successful build.

```
moragues@moragues-cloud:~/chromeos/main/src/third_party/coreboot$ git diff
diff --git a/src/mainboard/google/brox/Kconfig b/src/mainboard/google/brox/Kconfig
index 93960eb2255..a62fc1e3970 100644
--- a/src/mainboard/google/brox/Kconfig
+++ b/src/mainboard/google/brox/Kconfig
@@ -5,6 +5,7 @@ config ACPI_FNKEY_GEN_SCANCODE

config BOARD_GOOGLE_BROX_COMMON
        def_bool n
+
        select DRIVERS_GENERIC_GPIO_KEYS
        select DRIVERS_I2C_GENERIC
        select DRIVERS_I2C_HID
@@ -87,7 +88,7 @@ config BOARD_GOOGLE_JUBILANT
        select BOARD_GOOGLE_BASEBOARD_BROX
        select CHROMEOS_WIFI_SAR if CHROMEOS
        select USE_UNIFIED_AP_FIRMWARE_FOR_UFS_AND_NON_UFS
-
+       select DRIVERS_GENERIC_ALC1015
 if BOARD_GOOGLE_BROX_COMMON

config BASEBOARD_DIR
diff --git a/src/mainboard/google/brox/variants/jubilant/gpio.c b/src/mainboard/google/brox/variants/jubilant/gpio.c
index 4e6ec535db7..6293f68b0d5 100644
--- a/src/mainboard/google/brox/variants/jubilant/gpio.c
+++ b/src/mainboard/google/brox/variants/jubilant/gpio.c
@@ -1,4 +1,4 @@
-* SPDX-License-Identifier: GPL-2.0-or-later */
+/* SPDX-License-Identifier: GPL-2.0-or-later */

#include <baseboard/gpio.h>
 #include <baseboard/variants.h>
diff --git a/src/mainboard/google/brox/variants/jubilant/overridetree.cb b/src/mainboard/google/brox/variants/jubilant/overridetree.cb
index ce40ce90a7f..fbcd8d3a133 100644
--- a/src/mainboard/google/brox/variants/jubilant/overridetree.cb
+++ b/src/mainboard/google/brox/variants/jubilant/overridetree.cb
@@ -411,7 +411,7 @@ chip soc/intel/alderlake
                                register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D2)"
                                register "enable_delay_ms" = "3"
                                device spi 0 on
-                                       probe FP_MCU FP_MCU_NUVOTON
+                                       probe FPMCU FP_MCU_NUVOTON
                                end
                        end # FPMCU
                end
```