Attention is currently required from: Bhanu Prakash Maiya, Eric Peers, Karthik Ramasubramanian. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59051 )
Change subject: mb/google/guybrush: Update SPKR GPIO configuration for guybrush/nipperkin ......................................................................
Patch Set 6:
(3 comments)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/59051/comment/5640c003_f0ba3290 PS5, Line 70: PAD_GPO(GPIO_31, HIGH),
Please make this PAD_NC(GPIO_31)
Done
File src/mainboard/google/guybrush/variants/guybrush/gpio.c:
https://review.coreboot.org/c/coreboot/+/59051/comment/7f1d4202_fa6392b0 PS5, Line 13: PAD_NC(GPIO_31),
nit: could be removed.
Done
File src/mainboard/google/guybrush/variants/nipperkin/gpio.c:
https://review.coreboot.org/c/coreboot/+/59051/comment/b81dec06_eecf89b1 PS5, Line 39: /* Unused */
Override for GPIO_31 and GPIO_70 is not needed here because it matches base_gpio. Please remove.
Done