Attention is currently required from: Lean Sheng Tan, Paul Menzel.
Mario Scheithauer has posted comments on this change by Mario Scheithauer. ( https://review.coreboot.org/c/coreboot/+/84399?usp=email )
Change subject: soc/intel/ehl/fsp_params: Do not re-enable 'PchPwrOptEnable' for real-time tuning
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84399/comment/b5ae8120_bd332e13?usp... :
PS3, Line 7: Fix double setting of 'PchPwrOptEnable'
I misunderstood the summary. Maybe something like: […]
Done
https://review.coreboot.org/c/coreboot/+/84399/comment/4e0df6df_4f5436fb?usp... :
PS3, Line 9: If real-time tuning was enabled, 'PchPwrOptEnable' was set two times.
… with different values.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84399?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f31015c1da51a4ae1b8d5226f5d7b60a6023f3d
Gerrit-Change-Number: 84399
Gerrit-PatchSet: 4
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Wed, 18 Sep 2024 05:26:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org