Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36591 )
Change subject: console: serial: add optional delay to wait for BMC serial routing
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36591/1/src/console/Kconfig
File src/console/Kconfig:
https://review.coreboot.org/c/coreboot/+/36591/1/src/console/Kconfig@161
PS1, Line 161: depends on BOOTBLOCK_CONSOLE
@Patrick Ouch. […]
If it were taking that long to get to romstage... that would imply the
bootblock takes 2x longer than the whole coreboot on some boards ^^
You could try to get your hands on the first timestamp and then delay
appropriately. I assume, everything else would result in an `if` mess.
Btw. when I first saw this, I thought "why doesn't he do it in
bootblock_mainboard_early_init()?". Guaranteed to run only once
per boot and explicitly executed before console_init().
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36591
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d6599b76384fc94a00a9cfc1794ebfe34863ff9
Gerrit-Change-Number: 36591
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 03 Nov 2019 10:09:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment