Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38247 )
Change subject: soc/intel/common/cse: Add consistent HECI command id/group id naming
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38247/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/38247/3/src/soc/intel/common/block/...
PS3, Line 23:
nit: In the next CL, you are updating to use tabs for other macro definitions. It would be good to be consistent here as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38247
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia902095483d5badf778d0c1faa6bf8cc431f0e50
Gerrit-Change-Number: 38247
Gerrit-PatchSet: 3
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 11 Jan 2020 18:05:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment