Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63926 )
Change subject: mb/google/corsola: Enable CBFS_VERIFICATION
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/corsola/Kconfig:
https://review.coreboot.org/c/coreboot/+/63926/comment/362f892c_1cf02479
PS5, Line 26: CBFS_VERIFICATION
Should we move this to config config VBOOT, or maybe "select CBFS_VERIFICATION if VBOOT"? […]
Sorry, this shouldn't be here at all. It's a user decision, not describing the hardware. So we should add it in the coreboot ebuild config file. (Idk if we have a ti50 USE flag... if we do, maybe the ebuild could add this automatically based on that rather than having to add it to each individual config.<board> file.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63926
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b85ead37e1e88730fecf9d6b0259d7cad7229fa
Gerrit-Change-Number: 63926
Gerrit-PatchSet: 5
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 03 May 2022 01:10:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment