Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46676 )
Change subject: UPSTREAM: mb/google/volteer/variants/delbin: Update DPTF parameters for delbin ......................................................................
Patch Set 9:
(6 comments)
https://review.coreboot.org/c/coreboot/+/46676/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46676/4/src/mainboard/google/voltee... PS4, Line 63: 15000
Yes, this looks like a typo. These need to be different. […]
Done
https://review.coreboot.org/c/coreboot/+/46676/4/src/mainboard/google/voltee... PS4, Line 63: .pl1 = {.min_power = 15000, : .max_power = 15000,
PL1 min max set to the same value looks weird. I'm not quite sure if this is reasonable.
Done
https://review.coreboot.org/c/coreboot/+/46676/4/src/mainboard/google/voltee... PS4, Line 68: .pl2 = {.min_power = 51000, : .max_power = 51000,
as here.
Done
https://review.coreboot.org/c/coreboot/+/46676/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46676/7/src/mainboard/google/voltee... PS7, Line 4:
TCC and PL1/PL2 ovveride settings are missing. Can you please add the below - […]
Done
https://review.coreboot.org/c/coreboot/+/46676/7/src/mainboard/google/voltee... PS7, Line 39: 15000
Can you also please help address this? This should be 3000 as per your report.
Done
https://review.coreboot.org/c/coreboot/+/46676/7/src/mainboard/google/voltee... PS7, Line 44: 51000
This should be 15000
Done