Attention is currently required from: Paul Menzel, Angel Pons.
Boris Mittelberg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56840 )
Change subject: mb/google/dedede: allow MKBP devices
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56840/comment/d167bdce_a6501359
PS3, Line 9: MKBP
What does MKBP mean? I'd appreciate if this information could be added to the commit message
It stands for Matrix Keyboard Protocol - one of the 2 "keyboard" interfaces on chromeos devices. MKBP is more generic than 8042, and it allows non-keyboard events to be delivered from EC (Embedded Controller) to the host. Before this change 8042 was used for other events like Power button, Lid switch, etc, which are not really part of the keyboard.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56840
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d1f43e4dd56318af4c1d5f5c1c3a2c237a05c5f
Gerrit-Change-Number: 56840
Gerrit-PatchSet: 3
Gerrit-Owner: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Aseda Aboagye
aaboagye@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 10 Aug 2021 19:30:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment